Publish to PyPI on release #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bbayles
commented
Jun 5, 2023
Comment on lines
+16
to
+18
| release: | ||
| types: | ||
| - published |
There was a problem hiding this comment.
Needed for the new upload_all job below, which has:
if: github.event_name == 'release' && github.event.action == 'published'
bbayles
commented
Jun 5, 2023
| @@ -21,20 +25,38 @@ jobs: | |||
| build_wheels: | |||
| strategy: | |||
| matrix: | |||
| os: ["ubuntu-20.04", "macos-11"] | |||
| os: ["ubuntu-latest", "macos-latest"] | |||
There was a problem hiding this comment.
cibuildwheel should take care of the compatibility for older platforms
anonrig
approved these changes
Jun 5, 2023
|
Do we need to pass any secrets to Github for Pypi? |
|
Per this document, no - notice how the |
|
Nice. Let's merge and try publishing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: Issue #15, this PR updates the
build.ymlfile such that:.tar.gz) is created.whl) are uploaded to PyPII am drawing from these docs:
cibuildwheel/examples/github-deploy.ymlI have created a GitHub "environment" called
releasefor publishing. I will configure PyPI to use it as well.